fix: two typos in predict_merges comparing wrong PageElement fields(#146)#152
Open
RayVR wants to merge 1 commit intodocling-project:mainfrom
Open
fix: two typos in predict_merges comparing wrong PageElement fields(#146)#152RayVR wants to merge 1 commit intodocling-project:mainfrom
RayVR wants to merge 1 commit intodocling-project:mainfrom
Conversation
Contributor
|
✅ DCO Check Passed Thanks @RayVR, all your commits are properly signed off. 🎉 |
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
RayVR
force-pushed
the
fix/predict-merges-page-no-typo
branch
from
46093f4 to
cb9af65
Compare
(docling-project#146) Line 186: compared PageElement object to DocItemLabel enums instead of comparing .label, preventing the skip-loop from ever executing. Line 200: compared page_no to .label instead of .page_no, making the cross-page check always true and bypassing the is_strictly_left_of guard. Signed-off-by: Raymond Roberts <[email protected]>
RayVR
force-pushed
the
fix/predict-merges-page-no-typo
branch
from
cb9af65 to
1be2aca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 186: compared PageElement object to DocItemLabel enums instead of comparing .label, preventing the skip-loop from ever executing.
Line 200: compared page_no to .label instead of .page_no, making the cross-page check always true and bypassing the is_strictly_left_of guard.
Issue resolved by this Pull Request:
Resolves #146 #98
Checklist: